feat: contract bindings #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeneePatel
requested review from
drspacemn,
glihm and
b-j-roberts
as code owners
drspacemn
reviewed
Apr 11, 2024
There was a problem hiding this comment.
Thank you for this work!
Please change the name of the subdir to bindings/ to reflect the work done here:
https://github.com/keep-starknet-strange/blobstream-starknet/pull/132/files
Other than that lgtm
|
Thanks alot sire! Renamed the subdir |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used cainome to create the rust bindings. but not sure which bindings are to be made public from the library or all.
First time doing this and will need some guidance for next steps.