Calculate class_commitment from proof #460
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around an issue introduced when Pathfinder removed
class_commitment
from its class proof.Any proof starts with the root node, and hashing that root node gives the Merkle root of that tree.
class_commitment
is really just the Merkle root of the class tree, so this is all we need to reconstruct it.Note, however, that this is redundant --
verify_proof()
ultimately hashes the root node and compares that toclass_commitment
, which is exactly what this PR does. It would be just as good to makeclass_commitment
anOption
an only verify it then; but this PR at least makes the problem clear.Type
Description
Breaking changes?