Add verify workflow and specify node version #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HarlemSquirrel
commented
Apr 16, 2024
•
HarlemSquirrel
commented
- Verify with linters and by building the browser extensions on each push.
- Add web-ext
- Specify the same node version we're using with the main app.
|
Is this one ready to go or are you still adding? I'd try to see if we can bump prettier to v3 since that's what KeeWeb is running on now, then the configs can be used across the board. I made a really nice config for ESLint, but there are still plugins not compatible with the latest version, so I have to wait. |
|
This is ready if it looks good to you |
|
I can try bumping prettier |
|
Prettier v3 die on you? |
Yeah, led me down dependency hell. Opened new PR to work on node 18 and hopefully prettier 3 |
|
Trust me, already went through that with KeeWeb. I lost a week of my life just fixing that mess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.