feat: mvp zed extension going #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraisr
commented
Dec 17, 2024
packages/hdx_zed/src/lib.rs
Outdated
| &zed::LanguageServerInstallationStatus::Downloading, | ||
| ); | ||
|
|
||
| zed::download_file(&asset.download_url, "bin", zed::DownloadedFileType::Zip) |
There was a problem hiding this comment.
Once we have the release assets going, this line may need to change a tad. As in is it bin/binary-platform-arch??
keithamus
approved these changes
Dec 17, 2024
keithamus
reviewed
Dec 17, 2024
maraisr
commented
Dec 18, 2024
| @@ -96,13 +96,14 @@ jobs: | |||
| BIN_NAME=hdx-${{ matrix.code-target }} | |||
| mv target/${{ matrix.target }}/release/hdx $BIN_NAME | |||
|
|
|||
| - run: chmod +x hdx-* | |||
There was a problem hiding this comment.
I needed zed::make_file_executable in the extension, which we don't need to do; if we chmod +x the binary.
I believe these file modes are transfered through the assets; but wasnt too sure so kept the zed fn api to +x it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get's a Zed Extension impl going. Where the LSP is downloaded from GitHub release assets.
Even though Zed extensions are Rust projects, we shouldn't include that as part of our
hdxworkspace. Furthermore, we should treat the lsp as external, and not try to compile our lsp directly within the extension wasm.The
lsplocation is resolved through either;HDX_SERVER_PATH(which is the same as the VSCode one)