Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WeebCentral: Exclude special characters #7164

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

dngonz
Copy link
Contributor

@dngonz dngonz commented Jan 13, 2025

Closes #7157

There are special characters that when searching gives an error or return empty results

Tested with:

  • Don't Blush, Sekime-san!
  • Golden Time (Umechazuke)
  • #Killstagram
  • ID:INVADED #BRAKE BROKEN

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

@Hellkaros
Copy link
Contributor

I think the best approach wouldn't be to exclude special characters, especially because if you search the site for just '!', manga titles will show up. The extension doesn't need an update since the path used to develop the search was based on 'advanced search.' However, on the site, if you go to 'advanced search' and search for 'Don't Blush, Sekime-san!', there won't be any results. In this case, it would be a matter of modifying the searchMangaRequest method to perform the search using 'Quick search' instead of 'advanced search.'

@AwkwardPeak7 AwkwardPeak7 merged commit 9b60f9e into keiyoushi:main Jan 15, 2025
2 checks passed
@dngonz dngonz deleted the weebcentral branch January 15, 2025 15:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weeb Central: Searching (titles) with "!" gives no results found
3 participants