Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MadTheme: Enhance chapter parse #7214

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

dngonz
Copy link
Contributor

@dngonz dngonz commented Jan 17, 2025

Closes #3976

Now instead of just get chapters request by slug first try to get it by id.
Tested on all 14 extension that use it, but if someone found any other error please report.

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

@@ -177,30 +174,45 @@ abstract class MadTheme(
}

override fun chapterListParse(response: Response): List<SChapter> {
if (response.code in 200..299) {
if (response.request.url.fragment == "idFound") {
Copy link
Contributor

@AwkwardPeak7 AwkwardPeak7 Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you return this idFound in chapterListRequest everytime, so when would the later code be called/necessary?

edit: nvm i missread the code

@AwkwardPeak7 AwkwardPeak7 merged commit 2e1c127 into keiyoushi:main Jan 20, 2025
2 checks passed
@dngonz dngonz deleted the madtheme branch January 20, 2025 06:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MangaBuddy Fetching the wrong series
3 participants