Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup layout and styling enhancements #415

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

hazzuk
Copy link

@hazzuk hazzuk commented Aug 15, 2024

Description

This PR makes changes to the popup window by changing the placement of UI elements and improving the overall look and feel through styling.

Motivation

The previous interface (whilst perfectly functional) suffers from some key issues I set out to solve:

  • The media buttons are placed separately, creating large areas of unused space
  • Media buttons are placed too far away from other controls and the center of the page
  • Lack of cohesion between different UI elements

Changes

  • Numerous styling changes to create a more modern, homogeneous and less distracting design
  • Media buttons are now placed at the bottom of the window alongside other toolbar buttons
  • The 'report issues' link is now a toolbar button
  • A dedicated 'announcements' element was added, which is also now dismissible
  • Improvements to toolbar buttons in light mode to ensure better visibility
  • Structural changes using CSS grid/flex to avoid a need of hardcoded width/height values

Testing

My tests included some of the following:

  • Both the popup box in it's standard mode and as a separate window
  • All controls present in the window
  • Restarting playback and restarting the browser
  • Ensuring any errors are also still correctly displayed

Screenshots

Popup
New (with announcement hidden)

read-aloud_new-full

Popup
New/previous

read-aloud_new read-aloud_old

Separate window (dark mode)
New/previous

read-aloud_popout-dark

Separate window (light mode)
New/previous

read-aloud_popout-light

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant