Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file license header script #2472

Merged
merged 11 commits into from
Dec 19, 2023
Merged

Add file license header script #2472

merged 11 commits into from
Dec 19, 2023

Conversation

chrisgervang
Copy link
Collaborator

@chrisgervang chrisgervang commented Dec 7, 2023 •
edited
Loading

For #2467. Alternatively to #2470 , we can keep the script that adds license headers

@chrisgervang
Use new file license header
39e4a69 
Signed-off-by: Chris Gervang <[email protected]>
chrisgervang
chrisgervang commented Dec 7, 2023
View reviewed changes
LICENSE-HEADER Outdated
Comment on lines 1 to 2
Copyright contributors to the kepler.gl project
SPDX-License-Identifier: MIT
Copy link
Collaborator Author

@chrisgervang chrisgervang Dec 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that order matters due to an assumption made in uber-licence. So #2472 will need to be updated

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest copying the license-fixer.js file into kepler.gl/scripts and modifying that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forked it over, removed the parts causing issues, and made other necessary changes to get it to work (like ES modules and deps)

@chrisgervang
Use header file in modules
db5ee81 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
fix path
9f05981 
Signed-off-by: Chris Gervang <[email protected]>
ibgreen
ibgreen approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better copy the script so we can modify it.

LICENSE-HEADER Outdated
Comment on lines 1 to 2
Copyright contributors to the kepler.gl project
SPDX-License-Identifier: MIT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest copying the license-fixer.js file into kepler.gl/scripts and modifying that.

@chrisgervang
copy over the license script
6d9b181 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
remove copyright trim
a5da69e 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
remove uber-licence dep
39faeeb 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
Find ts, tsx files. Ignore dist folder
fc58fbd 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
modules
41e908d 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
fix ES modules
1187303 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang chrisgervang changed the title Use new file license header Add file license header script Dec 8, 2023
@chrisgervang
Copy link
Collaborator Author

chrisgervang commented Dec 8, 2023 •
edited
Loading

This is good to go. Once merged I can run yarn run babel-node ./scripts/license-header/bin --license ./FILE-HEADER --legacy ./LICENSE in #2471 and it'll migrate anything I missed.

@chrisgervang
more discoverable file header
10b7c3e 
Signed-off-by: Chris Gervang <[email protected]>
This was referenced Dec 8, 2023
Closed
Open
@ibgreen
Copy link
Collaborator

ibgreen commented Dec 19, 2023

@chrisgervang ready to merge?

@chrisgervang
Copy link
Collaborator Author

chrisgervang commented Dec 19, 2023 •
edited
Loading

Yes, but I need to do it within a few minutes of the header change PR to avoid messing up someone working on other PRs (it'll autogenerate 900+ changes on them). I'll block off time today to land these.

@chrisgervang chrisgervang merged commit 5092486 into keplergl:master Dec 19, 2023
5 checks passed
@chrisgervang chrisgervang deleted the chr/modify-uber-licence branch December 19, 2023 21:49
chrisgervang added a commit to chrisgervang/kepler.gl that referenced this pull request Dec 19, 2023
@chrisgervang
Add file license header script (keplergl#2472)
5d6b597 
* Use new file license header

Signed-off-by: Chris Gervang <[email protected]>

* Use header file in modules

Signed-off-by: Chris Gervang <[email protected]>

* fix path

Signed-off-by: Chris Gervang <[email protected]>

* copy over the license script

Signed-off-by: Chris Gervang <[email protected]>

* remove copyright trim

Signed-off-by: Chris Gervang <[email protected]>

* remove uber-licence dep

Signed-off-by: Chris Gervang <[email protected]>

* Find ts, tsx files. Ignore dist folder

Signed-off-by: Chris Gervang <[email protected]>

* modules

Signed-off-by: Chris Gervang <[email protected]>

* fix ES modules

Signed-off-by: Chris Gervang <[email protected]>

* more discoverable file header

Signed-off-by: Chris Gervang <[email protected]>

---------

Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang chrisgervang self-assigned this Dec 19, 2023
@chrisgervang chrisgervang added the chore Changes to the build process or auxiliary tools and libraries such as documentation generation label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees

@chrisgervang chrisgervang

Labels
chore Changes to the build process or auxiliary tools and libraries such as documentation generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisgervang @ibgreen