Fix image build #69
Merged
Fix image build #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theihor
force-pushed
the
packages-list-reorg
branch
2 times, most recently
from
030b6d9 to
c835311
Compare
|
Looks like we are not the only ones getting the python error on
|
Review and clean up the list of packages installed during runner image build: remove duplicates, use common list between main and s390x Dockerfiles. * remove linux-image-generic * replace python3 with python3-minimal. * install LLVM with an official automatic script. * set UBUNTU_VERSION to noble by default This addresses recent build failures: * https://github.com/kernel-patches/runner/actions/runs/13058686735 * https://github.com/kernel-patches/runner/actions/runs/13037837932 Signed-off-by: Ihor Solodrai <[email protected]>
Add theihor (Ihor Solodrai) to reviewers in version_bump workflow. Signed-off-by: Ihor Solodrai <[email protected]>
See: docker/setup-qemu-action#188 (comment) Signed-off-by: Ihor Solodrai <[email protected]>
theihor
force-pushed
the
packages-list-reorg
branch
from
730e943 to
2fe66e9
Compare
theihor
changed the title
|
Ok, this comment was very helpful: docker/setup-qemu-action#188 (comment) Looks like "default" qemu installed by |
theihor
added a commit
to libbpf/libbpf
that referenced
this pull request
Jan 31, 2025
The run-on-arch action is using docker to run things on various platforms. Docker in turn relies on qemu-user-static installed on the system. Recently there were various reports about multi-arch docker builds failing with seemingly random issues, and it appears to boil down to qemu [1]. I stumbled on this problem while updating s390x runners [2], and setting up more recent version of qemu helped. [1] docker/setup-qemu-action#188 [2] kernel-patches/runner#69 Signed-off-by: Ihor Solodrai <[email protected]>
theihor
added a commit
to libbpf/libbpf
that referenced
this pull request
Jan 31, 2025
The run-on-arch action is using docker to run things on various platforms. Docker in turn relies on qemu-user-static installed on the system. Recently there were various reports about multi-arch docker builds failing with seemingly random issues, and it appears to boil down to qemu [1]. I stumbled on this problem while updating s390x runners [2], and setting up more recent version of qemu helped. Install docker buildx and enforce it's usage with DOCKER_BUILDKIT=1 [3], so that it's used by run-on-arch action. [1] docker/setup-qemu-action#188 [2] kernel-patches/runner#69 [3] https://docs.docker.com/build/buildkit/#getting-started Signed-off-by: Ihor Solodrai <[email protected]>
theihor
added a commit
to theihor/libbpf
that referenced
this pull request
Jan 31, 2025
run-on-arch-action is simply a wrapper around docker. There is no value in using it in libbpf, as it is not complicated to run non-native arch docker images directly on github-hosted runners. Docker relies on qemu-user-static installed on the system to emulate different architectures. Recently there were various reports about multi-arch docker builds failing with seemingly random issues, and it appears to boil down to qemu [1]. I stumbled on this problem while updating s390x runners [2] for BPF CI, and setting up more recent version of qemu helped. This change addresses recent build failures on s390x and ppc64le. [1] docker/setup-qemu-action#188 [2] kernel-patches/runner#69 [3] https://docs.docker.com/build/buildkit/#getting-started Signed-off-by: Ihor Solodrai <[email protected]>
anakryiko
pushed a commit
to libbpf/libbpf
that referenced
this pull request
Feb 1, 2025
run-on-arch-action is simply a wrapper around docker. There is no value in using it in libbpf, as it is not complicated to run non-native arch docker images directly on github-hosted runners. Docker relies on qemu-user-static installed on the system to emulate different architectures. Recently there were various reports about multi-arch docker builds failing with seemingly random issues, and it appears to boil down to qemu [1]. I stumbled on this problem while updating s390x runners [2] for BPF CI, and setting up more recent version of qemu helped. This change addresses recent build failures on s390x and ppc64le. [1] docker/setup-qemu-action#188 [2] kernel-patches/runner#69 [3] https://docs.docker.com/build/buildkit/#getting-started Signed-off-by: Ihor Solodrai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review and clean up the list of packages installed during runner image build: remove duplicates, use common list between main and s390x Dockerfiles.
This addresses recent build failures: