Skip to content

Commit

Permalink
fix: small fizes in boots tab
Browse files Browse the repository at this point in the history
- move srtings to locale file
- add brackets that were missing in html component
  • Loading branch information
mari1912 committed Aug 20, 2024
1 parent abe96cc commit 77b7e58
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions dashboard/src/locales/messages/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ export const messages = {
'bootsTab.configs': 'Configs',
'bootsTab.error': 'Error',
'bootsTab.errorsSummary': 'Errors Summary',
'bootsTab.fail': 'Fail',
'bootsTab.info': 'Info',
'bootsTab.info.description':
'ℹ️ There is no boot test data available for this tree',
Expand Down
6 changes: 3 additions & 3 deletions dashboard/src/pages/TreeDetails/Tabs/Boots/BootsTab.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,15 @@ const BootsTab = (): JSX.Element => {
}

if (isLoading) {
return <div>Loading...</div>;
return <FormattedMessage id="global.loading" />;
}

if (!data) return <div />;

if (data.testHistory.length < 1) {
return (
<BaseCard
title=<FormattedMessage id="bootsTab.info" />
title={<FormattedMessage id="bootsTab.info" />}
content={
<p className="p-4 text-[1.3rem] text-darkGray">
ℹ️ <FormattedMessage id="bootsTab.info.description" />
Expand Down Expand Up @@ -72,7 +72,7 @@ const BootsTab = (): JSX.Element => {
platformsWithError={data.platformsWithError}
/>
<MemoizedErrorCountList
title={<>Fail</>}
title={<FormattedMessage id="bootsTab.fail" />}
errorMessageCounts={data.errorMessageCounts}
/>
</div>
Expand Down

0 comments on commit 77b7e58

Please sign in to comment.