fix(#20): set the start index correctly when some filter is applied #107
Conversation
mari1912
commented
Aug 14, 2024
mari1912
commented
- closes [Bug] [Builds Tab] Itens navigation breaks after filters change #20
| @@ -13,6 +13,7 @@ export const usePagination = ( | |||
| const [endIndex, setEndIndex] = useState(0); | |||
|
|
|||
| useEffect(() => { | |||
| setStartIndex(0); //restart the index whenever there is a change in filters | |||
There was a problem hiding this comment.
this won't work if the itemsPorPage and totalItems have the same count, needs to add diffFilter and filter to the dependency array
There was a problem hiding this comment.
you will need useSearch for this one
There was a problem hiding this comment.
Can you give me an example when it's possible? I tried with http://localhost:5173/tree/0bdf955f408e17b64d9dc4de09d3a2fc4f233aca?tableFilter=all¤tTreeDetailsTab=treeDetails.builds&diffFilter=%7B%7D changing the itemsPerPage and it doesn't seem to be broken
There was a problem hiding this comment.
it will be a rare case if not never, but it is possible since are primitives in javascript and the useEffect wont detect a change if they are the same but coming from another source
mari1912
force-pushed
the
fix/table-navigation
branch
from
c351dfe to
0b6bcea
Compare
mari1912
force-pushed
the
fix/table-navigation
branch
from
0b6bcea to
0aac5ed
Compare
mari1912
force-pushed
the
fix/table-navigation
branch
from
0aac5ed to
718726b
Compare
