feat: add origin selector #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mari1912
reviewed
Aug 15, 2024
| return ( | ||
| <SelectUI {...propsWithoutChildren}> | ||
| <SelectTrigger className="w-auto rounded-full border-2 border-dimGray px-6 py-4 text-base font-medium text-dimGray"> | ||
| <SelectValue placeholder="Theme" /> |
There was a problem hiding this comment.
should we add a better placeholder and make it use i18n?
There was a problem hiding this comment.
actually this shouldn't be here, i was using it for testing purposes. Nice catch
|
|
||
| return ( | ||
| <div className="flex items-center"> | ||
| <span className="mr-4 text-base font-medium text-dimGray">Origin</span> |
| <div className="flex w-full flex-row items-center justify-between"> | ||
| <span className="text-2xl"> | ||
| <div className="flex flex-row items-center justify-between"> | ||
| <span className="mr-14 text-2xl"> |
There was a problem hiding this comment.
just make sure it will be aligned with other content, because of the changes we are making
lfjnascimento
force-pushed
the
feat/add_origin_selector
branch
from
d7009b0 to
381a0d0
Compare
mari1912
approved these changes
Aug 15, 2024
| return ( | ||
| <SelectUI {...propsWithoutChildren}> | ||
| <SelectTrigger className="w-auto rounded-full border-2 border-dimGray px-6 py-4 text-base font-medium text-dimGray"> | ||
| <SelectValue placeholder="Theme" /> |
lfjnascimento
force-pushed
the
feat/add_origin_selector
branch
from
381a0d0 to
defa4cd
Compare
lfjnascimento
force-pushed
the
feat/add_origin_selector
branch
from
defa4cd to
c64d035
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #78