feat: add FilterList to TreeDetails page #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mari1912
reviewed
Jul 23, 2024
There was a problem hiding this comment.
It is working ok, but I noticed some things that could be improved:
- An error happens if i open the filters model, select one and close the modal without filtering it, when i open it again and select other filter it will add the both of them, even though the first one is not selected
- hover clean all state is too light, we cannot read the text
- about status filter: true or false doesn't make sense
- we should check what this refresh button is suppose to do, I don't think this should be there right now
| @@ -92,7 +92,7 @@ const FilterList = ({ | |||
| [itens, onClickItem], | |||
| ); | |||
|
|
|||
| if (removeOnEmpty && !itens) { | |||
| if (removeOnEmpty && !itens.length) { | |||
Comment on lines
+73
to
+83
| if (newFilter[filterField]) { | ||
| newFilter[filterField][value] = isSelected; | ||
| } else { | ||
| newFilter[filterField] = { | ||
| [value]: isSelected, | ||
| }; | ||
| } |
There was a problem hiding this comment.
your call, but what about using ternary operator?
There was a problem hiding this comment.
I prefer to use ternary only in expressions
Comment on lines
169
to
170
| const treeUrl = | ||
| 'https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git'; |
There was a problem hiding this comment.
this should not be a const, it should change according to the tree you are in
| @@ -15,9 +15,14 @@ export interface ITabItem { | |||
| export interface ITabsComponent { | |||
| tabs: ITabItem[]; | |||
| defaultTab: ITabItem; | |||
| FilterListElement?: JSX.Element; | |||
| @@ -48,6 +53,8 @@ const TabsComponent = ({ defaultTab, tabs }: ITabsComponent): JSX.Element => { | |||
| return ( | |||
| <Tabs defaultValue={defaultTab.name} className="w-full"> | |||
| <TabsList className="w-full justify-start">{tabsTrigger}</TabsList> | |||
| <div className="py-6">{FilterListElement}</div> | |||
There was a problem hiding this comment.
I'm not sure it is worth it for us to pass the whole element instead of a list with the filters and call the necessary ui here
There was a problem hiding this comment.
In terms of processing, it's basically the same thing, we are passing a "reference" in both situations, but we gain more flexibility by passing an element here
mari1912
approved these changes
Jul 23, 2024
lfjnascimento
force-pushed
the
fix/filter_
branch
2 times, most recently
from
4719c71 to
63e4ca3
Compare
- make onClickItemHandler pass the value to onClickItem - fix typo itens - fix color on hover on cleanAll button
- make the TreeDetails page own the filter instead of TreeDetailsFilter so we can pass the filter to other components like FilterList
- also add TreeUl as prop
lfjnascimento
force-pushed
the
fix/filter_
branch
from
63e4ca3 to
777bc55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual reference