Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(get-tree-details-data): fix return position #794

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

murilx
Copy link
Contributor

@murilx murilx commented Jan 20, 2025

Closes #785

How to test

  • Test with no cache (default behavior in development environment)
  • Test with cache by changing the settings.py file to:
if DEBUG:
    CORS_ALLOWED_ORIGIN_REGEXES = [
        r"^http://localhost",  # dashboard dev server
    ]
    SESSION_COOKIE_SECURE = False
    CSRF_COOKIE_SECURE = False
    SECURE_SSL_REDIRECT = False
    SECURE_HSTS_SECONDS = 3600
    # CACHE_TIMEOUT = 0
    CACHE_TIMEOUT = 3600

@murilx murilx marked this pull request as ready for review January 20, 2025 14:36
@murilx murilx self-assigned this Jan 20, 2025
Copy link
Collaborator

@MarceloRobert MarceloRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to have fixed the problems, these things are hard to spot

Copy link
Collaborator

@Francisco2002 Francisco2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!!!!

@murilx murilx merged commit 61e92d7 into main Jan 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make staging great again
3 participants