Fix: tree details broonie #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Francisco2002
force-pushed
the
fix/tree-details-broonie
branch
from
370ddd0 to
02ca16a
Compare
WilsonNet
reviewed
Jan 21, 2025
|
graph is returning the wrong data |
WilsonNet
approved these changes
Jan 21, 2025
Francisco2002
force-pushed
the
fix/tree-details-broonie
branch
from
02ca16a to
2f7bcf6
Compare
MarceloRobert
approved these changes
Jan 21, 2025
- remove enable props from the useCommitHistory hook Close #729
Francisco2002
force-pushed
the
fix/tree-details-broonie
branch
from
2f7bcf6 to
bbc9b75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tree in broonie origin have no git url/branch (null field).
In this PR, I remove de validation on frontend to allow the user send a empty git url and git branch to the tree details endpoint, that now returns a error if no data was found.
In the backend, add a logic to search this trees when this fields are null.
How to test
Close #729