reapply: lazy load revert #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
WilsonNet
commented
Jan 21, 2025
WilsonNet
commented
- Reapply "fix(TreeDetails): add lazy load"
- Reapply "feat: add loading state to TreeDetails component"
WilsonNet
force-pushed
the
fix/lazy-load-to-full
branch
from
7850258 to
c4305b7
Compare
WilsonNet
force-pushed
the
fix/lazy-load-to-full
branch
2 times, most recently
from
fb5298d to
811a496
Compare
WilsonNet
force-pushed
the
fix/lazy-load-to-full
branch
from
811a496 to
2a17bab
Compare
- Added `process_filter` function to helpers/treeDetails.py, the function responsible to get the value of all possible filters in the tree details response - Added 'common' and 'filters' fields to tree details summary response - Added 'common' and 'filters' fields to tree details response Part of #792
Make the lazy load be tree details to full, so we don't get 4 requests, only two Renamed TTreeTestsFullData to TreeDetailsFullData across the codebase for better clarity and consistency. Updated all references and dependencies to use the new type name. Closes #791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.