Fix: filters extra query #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilx
commented
Jan 22, 2025
Comment on lines
37
to
53
| class TreeGlobalFilters(BaseModel): | ||
| configs: List[str] | ||
| architectures: List[str] | ||
| compilers: List[str] | ||
|
|
||
|
|
||
| class TreeLocalFilters(BaseModel): | ||
| issues: List[str] | ||
|
|
||
|
|
||
| class TreeFilters(BaseModel): | ||
| all: TreeGlobalFilters | ||
| builds: TreeLocalFilters | ||
| boots: TreeLocalFilters | ||
| tests: TreeLocalFilters | ||
|
|
||
|
|
There was a problem hiding this comment.
Do not forget to run sh generate_schema.sh
WilsonNet
reviewed
Jan 22, 2025
| @@ -478,3 +478,34 @@ def process_boots_summary(instance, row_data): | |||
| ] += 1 | |||
| else: | |||
| instance.bootEnvironmentMisc[test_platform][test_status] += 1 | |||
|
|
|||
|
|
|||
| def process_filters(instance, row_data) -> None: | |||
There was a problem hiding this comment.
you can type row_data as dict
There was a problem hiding this comment.
Since this whole file is using dict I'll stick to it, but there's an inconsistency between this file and the others that are using typing.Dict. I'd be willing to start using only dict from now on since it's they are equivalent and dict does not need any imports, but I'd rather keep the whole source code consistent so if we choose for typing.Dict it's ok as well
WilsonNet
reviewed
Jan 22, 2025
Comment on lines
76
to
81
| self.globalConfigs = set() | ||
| self.globalArchitectures = set() | ||
| self.globalCompilers = set() | ||
| self.unfilteredTestIssues = set() | ||
| self.unfilteredBootIssues = set() | ||
| self.unfilteredBuildIssues = set() |
WilsonNet
reviewed
Jan 22, 2025
Comment on lines
69
to
74
| self.globalConfigs = set() | ||
| self.globalArchitectures = set() | ||
| self.globalCompilers = set() | ||
| self.unfilteredTestIssues = set() | ||
| self.unfilteredBootIssues = set() | ||
| self.unfilteredBuildIssues = set() |
|
It is missing the |
WilsonNet
force-pushed
the
fix/lazy-load-to-full
branch
from
c4305b7 to
fb5298d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #792
DISCLAIMER: This PR was moved to #829