fix/lazy load summary to full #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilsonNet
changed the base branch from
main
to
fix/remove-filters-extra-query
WilsonNet
changed the title
WilsonNet
changed the title
WilsonNet
force-pushed
the
fix/lazy-load-to-full-for-real
branch
from
fb5298d to
6d5b888
Compare
WilsonNet
changed the base branch from
fix/remove-filters-extra-query
to
fix/lazy-load-to-full
WilsonNet
changed the title
WilsonNet
force-pushed
the
fix/lazy-load-to-full-for-real
branch
from
6d5b888 to
9e6e7fc
Compare
MarceloRobert
approved these changes
Jan 23, 2025
| const summaryData = summaryQuery.data?.summary.builds; | ||
| const { data: buildsData, status: buildsStatus } = buildsQuery; | ||
| const summaryData = treeDetailsLazyLoaded.summary?.data?.summary.builds; | ||
| const { data: fullData, status: buildsStatus } = treeDetailsLazyLoaded.full; |
There was a problem hiding this comment.
ditto about fullStatus
| const { tests: testsQuery, summary: summaryQuery } = treeDetailsLazyLoaded; | ||
| const { data, status, isLoading: testsIsLoading } = testsQuery; | ||
| const { full: fullQuery, summary: summaryQuery } = treeDetailsLazyLoaded; | ||
| const { data, status, isLoading: testsIsLoading } = fullQuery; |
There was a problem hiding this comment.
similar to the other renames, this should be fullIsLoading since it's no longer exclusive to tests
Make the lazy load be tree details to full, so we don't get 4 requests, only two Renamed TTreeTestsFullData to TreeDetailsFullData across the codebase for better clarity and consistency. Updated all references and dependencies to use the new type name. Closes #791
WilsonNet
force-pushed
the
fix/lazy-load-to-full-for-real
branch
from
90c5337 to
881c5fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make lazy load be Summary to Full instead of Summary to 3 endpoints
How to test
Enter in any tree details with the Network tab open and see how it goes.
Compare with the same result on staging
Closes #791