feat: add hardwareDetailsTests endpoint #831
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarceloRobert
force-pushed
the
feat/hardware-details-tests
branch
from
1d683cd to
dbe12ca
Compare
MarceloRobert
force-pushed
the
feat/hardware-details-summary
branch
2 times, most recently
from
0278c2a to
5d700f1
Compare
MarceloRobert
force-pushed
the
feat/hardware-details-tests
branch
from
dbe12ca to
ba6b50c
Compare
MarceloRobert
changed the base branch from
feat/hardware-details-summary
to
main
MarceloRobert
force-pushed
the
feat/hardware-details-tests
branch
from
ba6b50c to
1f2e1f5
Compare
murilx
reviewed
Jan 23, 2025
Comment on lines
93
to
97
| @extend_schema( | ||
| responses=HardwareDetailsTestsResponse, | ||
| ) |
There was a problem hiding this comment.
Suggested change
| @extend_schema( | |
| responses=HardwareDetailsTestsResponse, | |
| ) | |
| @extend_schema( | |
| responses=HardwareDetailsTestsResponse, | |
| request=HardwareDetailsPostBody, | |
| methods=["POST"], | |
| ) |
MarceloRobert
force-pushed
the
feat/hardware-details-tests
branch
2 times, most recently
from
8d87fc6 to
e70e674
Compare
Francisco2002
approved these changes
Jan 23, 2025
| def _process_test(self, record: Dict) -> None: | ||
| is_record_boot = is_boot(record["path"]) | ||
| if is_record_boot: | ||
| self.processed_tests.add(record["id"]) |
There was a problem hiding this comment.
you don't need to add a non processed tests in this set
MarceloRobert
force-pushed
the
feat/hardware-details-tests
branch
from
e70e674 to
695836f
Compare
MarceloRobert
force-pushed
the
feat/hardware-details-tests
branch
from
695836f to
ee5bec3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
/hardware/<hardware_name>/testsendpointHow to test
This endpoint is not being used by the frontend, but you can compare the responses by opening the network tab on the dashboard website, going to a hardware details with tests data, checking the request body for the post to hardwareDetails endpoint and use that body in a request from the api view. Check if filters and tree selection work normally.
Example: go to localhost:8000/api/hardware/brcm,bcm2711/tests and send the body
in the POST request
Part of #751
Closes #762