feat(api): Add documentation to some endpoints #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilx
force-pushed
the
feat/some-swagger-docs
branch
3 times, most recently
from
460c356 to
66b4b03
Compare
murilx
force-pushed
the
feat/some-swagger-docs
branch
from
66b4b03 to
e50b1a1
Compare
murilx
force-pushed
the
feat/some-swagger-docs
branch
4 times, most recently
from
41f4565 to
05bc22a
Compare
WilsonNet
reviewed
Jan 31, 2025
Comment on lines
19
to
46
| type Origin = str | ||
| type Timestamp = str | ||
|
|
||
| type Checkout__Id = str | ||
| type Checkout__TreeName = Optional[str] | ||
| type Checkout__GitCommitHash = Optional[str] | ||
| type Checkout__GitCommitName = Optional[str] | ||
| type Checkout__GitCommitTags = Optional[List[str]] | ||
|
|
||
| type Build__Id = str | ||
| type Build__Architecture = Optional[str] | ||
| type Build__ConfigName = Optional[str] | ||
| type Build__Valid = Optional[bool] | ||
| type Build__StartTime = Optional[datetime] | ||
| type Build__Duration = Optional[float] | ||
| type Build__Compiler = Optional[str] | ||
| type Build__Command = Optional[str] | ||
| type Build__Comment = Optional[str] | ||
| type Build__LogExcerpt = Optional[str] | ||
| type Build__LogUrl = Optional[str] | ||
| type Build__InputFiles = Optional[List[Dict[str, Any]]] | ||
| type Build__OutputFiles = Optional[List[Dict[str, Any]]] | ||
|
|
||
| type Test__Id = str | ||
| type Test__Status = Optional[str] | ||
| type Test__Duration = Optional[float] | ||
| type Test__Path = Optional[str] | ||
| type Test__StartTime = Optional[datetime] | ||
| type Test__EnvironmentCompatible = Optional[List[str]] |
There was a problem hiding this comment.
it actually looks decent, I think you can delete those old pydantic classes in this file also, we won't be using them
WilsonNet
reviewed
Jan 31, 2025
Comment on lines
+24
to
+31
| id: Build__Id | ||
| architecture: Build__Architecture | ||
| config_name: Build__ConfigName | ||
| valid: Build__Valid | ||
| start_time: Build__StartTime | ||
| duration: Build__Duration | ||
| compiler: Build__Compiler | ||
| log_url: Build__LogUrl |
There was a problem hiding this comment.
Really liked how it turned out as well
murilx
force-pushed
the
feat/some-swagger-docs
branch
from
c8c4685 to
002435f
Compare
murilx
force-pushed
the
feat/some-swagger-docs
branch
from
002435f to
3fc6228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #86