migrate deprecated tslint to typescript-eslint #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinptt0323
requested changes
Nov 8, 2019
| @@ -9,7 +9,8 @@ | |||
| "type:declaration": "tsc --noEmit false --emitDeclarationOnly --declaration --declarationDir ./dist", | |||
| "test": "cross-env TS_NODE_PROJECT=tsconfig.test.json mocha ./test/index.ts", | |||
| "build": "$npm_execpath run build:babel && $npm_execpath run type:declaration", | |||
| "build:babel": "cross-env NODE_ENV=production babel ./src --out-dir ./dist --extensions '.ts'" | |||
| "build:babel": "cross-env NODE_ENV=production babel ./src --out-dir ./dist --extensions '.ts'", | |||
| "linting": "eslint ./src/** --ext .ts" | |||
There was a problem hiding this comment.
Use lint.
eslint ./src --ext .ts
| @@ -246,10 +241,10 @@ class Bot extends EventEmitter { | |||
| if (getLine(21).str.includes('密碼不對或無此帳號')) { | |||
| this.emit('login.failed'); | |||
| return false; | |||
| } else if (getLine(23).str.includes('請稍後再試')) { | |||
| } if (getLine(23).str.includes('請稍後再試')) { | |||
There was a problem hiding this comment.
Can we disable no-else-return rule?
| }, | ||
| "parser": "@typescript-eslint/parser", | ||
| "parserOptions": { | ||
| "project": "tsconfig.json", |
There was a problem hiding this comment.
./tsconfig.json is preferred
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npx tslint-to-eslint-config --tslint .tslint.jsonto generate.eslintrc.jsautomatically@typescript-eslintpackage.jsonto run eslint--fixflag