Windows does not identify folders correctly in zip

[binary-koan]

I'm trying to extract https://github.com/HaxeFoundation/haxe/releases/download/3.2.1/haxe-3.2.1-win.zip using decompress 4.0.0, but get a whole bunch of errors like

Error: EISDIR: illegal operation on a directory, open '...\haxe-3.2.1\std\flash\geom'
    at Error (native)
  errno: -4068,
  code: 'EISDIR',
  syscall: 'open',
  path: '...\haxe-3.2.1\std\flash\geom'

from file entries like

{ mode: 420,
  mtime: 2015-10-11T11:00:44.000Z,
  path: 'haxe-3.2.1/std/flash/geom/',
  type: 'file',
  data: <Buffer > }

It looks like the directories in that archive are marked as type: file (instead of directory), but oddly enough it only happens for that particular archive.

A quick fix I found was to treat files as directories if their path ends with a '/' (i.e. if (x.type === 'directory' || x.path.endsWith('/')) { /* mkdir -p */ }), but I don't know if that's a good idea or not.

[vislamov]

Same here, switching to another lib...

[hzqst]

Same issue, switching to another lib tooooo...

[jeffmcaffer]

Same here. This is preventing temporarily unzip'd folders from being deleted (they are not empty) because the files in them are left open. fs.unlink marks them for deletion but does not empty the folder entry.

Moved to https://www.npmjs.com/package/extract-zip and that seems to work.

[dabutvin]

FWIW I had success working around this using a filter

decompress(source, destination, {
  filter: file => !file.path.endsWith('/')
})

[ahkohd]

FWIW I had success working around this using a filter

decompress(source, destination, {
  filter: file => !file.path.endsWith('/')
})

Worked like a charm, thanks!

[stheine]

The error is described in the module that's used for unzip: kevva/decompress-unzip#12

[LichKing-2234]

In my case, the file path does not end with '/'. But the data is empty. So the filter can be optimized:

const path = require('path');
...
filter: (file) => {
      return (
        file.type !== 'directory' &&
        !file.path.endsWith(path.sep) &&
        file.data.length !== 0
      );
    },