Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cld_steer: use tracking volume #57

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Zehvogel
Copy link
Collaborator

BEGINRELEASENOTES

  • Use Geant4TVUserParticleHandler by default in cld_steer.py

ENDRELEASENOTES

Now that the default is CLD_o2_v07 we can also default to the particle handler that uses the custom tracking region instead of just a cylinder.

@Zehvogel
Copy link
Collaborator Author

The broken test is ddsim_cld_arc but that one uses its own ddsim steering file which I did not touch. @atolosadelgado can you take a look?

@Zehvogel
Copy link
Collaborator Author

Ah never mind, cld_arc_steer.py imports everything, so we need to change back to Geant4TVUserParticleHandler there explicitly... But then we also need to set all the other SIM.part options again?

@atolosadelgado
Copy link
Contributor

atolosadelgado commented Dec 16, 2024

Ah never mind, cld_arc_steer.py imports everything, so we need to change back to Geant4TVUserParticleHandler there explicitly... But then we also need to set all the other SIM.part options again?

Hi! Thanks for checking it! If it is a problem how cld steer file is loaded into cld_arc_steer file, I can investigate an alternative to this, what do you think?

--
edit: sorry I saw your commit after I wrote this comment, thanks for fixing it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants