Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vendored go-winio #14494

Closed
wants to merge 3 commits into from
Closed

Conversation

zanderz
Copy link
Contributor

@zanderz zanderz commented Oct 30, 2018

to include our second PR against microsoft/go-winio: microsoft/go-winio#101

@zanderz zanderz requested review from maxtaco and a team October 30, 2018 22:25
@zanderz
Copy link
Contributor Author

zanderz commented Oct 31, 2018

Note this did seem to have fixed the user's crash after all

@zanderz
Copy link
Contributor Author

zanderz commented Nov 1, 2018

@maxtaco I'd like to get this in - can't figure out CI, the exact same code change worked the first time through. Thoughts?

@maxtaco
Copy link
Contributor

maxtaco commented Nov 1, 2018

CI seems like a CI bug.

@zanderz zanderz closed this Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants