Implement new CI on Github Actions #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evgenyp67 I've added you as a reviewer since some of my changes involve the new loader component. Please let me know if you see any issues, but with these changes the 32-bit configurations should also be fully supported now. |
grg-haas
force-pushed
the
bugfix/buildroot-ci
branch
2 times, most recently
from
ac68649 to
fb658d9
Compare
grg-haas
force-pushed
the
bugfix/buildroot-ci
branch
from
fb658d9 to
0ac7807
Compare
evgenyp67
requested changes
Dec 29, 2023
There was a problem hiding this comment.
The changes look great, very happy that we will soon have CI back on!
The only issue I saw is in test-system.yml I noticed that tests.ke is ran but attestor.ke is not. The latter tests that the attestation report is equal to the expected one, while tests.ke only checks that the report is successfully generated. I believe we should do both.
|
Thanks @evgenyp67 ! I've added the attestation test as well. @dayeol , any thoughts? |
evgenyp67
approved these changes
Dec 29, 2023
asyarifstudio
pushed a commit
to ThalesGroup/keystone
that referenced
this pull request
Jan 8, 2024
This PR creates a new efficient CI system for the Buildroot-based build system introduced a while ago. It includes full build tests for each supported platform (currently `generic` and `unmatched`, with `cva6` and `mpfs` landing soon) as well as full-stack runtime tests for the 32 and 64-bit generic platforms. CI times are kept low by heavily relying on Github Actions caching, where we save the latest compiler cache and Buildroot package cache at the end of each run. On average, the `generic` platforms build in 10 minutes while the `unmatched` platform builds in 13 (with a hot cache). With a cold cache, the builds take about an hour but will then refresh the caches so that future ones take much less time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new efficient CI system for the Buildroot-based build system introduced a while ago. It includes full build tests for each supported platform (currently
genericandunmatched, withcva6andmpfslanding soon) as well as full-stack runtime tests for the 32 and 64-bit generic platforms. CI times are kept low by heavily relying on Github Actions caching, where we save the latest compiler cache and Buildroot package cache at the end of each run. On average, thegenericplatforms build in 10 minutes while theunmatchedplatform builds in 13 (with a hot cache). With a cold cache, the builds take about an hour but will then refresh the caches so that future ones take much less time.