Skip to content

Commit

Permalink
Fix slack notification url (#10388)
Browse files Browse the repository at this point in the history
Co-authored-by: Bernie Birnbaum <[email protected]>
  • Loading branch information
npolshakova and bewebi authored Dec 6, 2024
1 parent ee4fc25 commit 5974a88
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/docs-gen.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -136,5 +136,5 @@ jobs:
run : |
curl -X POST\
-H 'Content-type: application/json'\
--data '{"text":"Gloo Edge has <https://github.com/solo-io/gloo/actions/runs/${{github.run_id}}|failed a docs build> on `main` branch"}'\
--data '{"text":"k8sgateway has <https://github.com/k8sgateway/k8sgateway/actions/runs/${{github.run_id}}|failed a docs build> on `main` branch"}'\
${{ env.SLACK_DEBUG_TESTING == true && secrets.SLACK_INTEGRATION_TESTING_WEBHOOK || secrets.EDGE_TEAM_BOTS_WEBHOOK }}
2 changes: 1 addition & 1 deletion .github/workflows/nightly-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ jobs:
go-version-file: go.mod
- name: Send Slack Message
env:
PARENT_JOB_URL: https://github.com/solo-io/gloo/actions/runs/${{github.run_id}} # parent job hyperlink
PARENT_JOB_URL: https://github.com/k8sgateway/k8sgateway/actions/runs/${{github.run_id}} # parent job hyperlink
PREAMBLE: ${{ steps.compute-preamble.outputs.preamble }} # text to hyperlink at start of slack message
SLACKBOT_BEARER: ${{ secrets.SLACKBOT_BEARER }}
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/push-docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ jobs:
env:
SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
run: |
JOB_URL=https://github.com/solo-io/gloo/actions/runs/${GITHUB_RUN_ID}
JOB_URL=https://github.com/k8sgateway/k8sgateway/actions/runs/${GITHUB_RUN_ID}
MESSAGE="❌ *Failure:* Automated copy of reference docs for ${{ steps.version-variables.outputs.minor }} failed. <${JOB_URL}|Review the workflow failure>"
curl \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/trivy-analysis-scheduled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,5 +48,5 @@ jobs:
run : |
curl -X POST\
-H 'Content-type: application/json'\
--data '{"text":"Gloo Edge Vulnerability Scan has failed, visit https://github.com/solo-io/gloo/actions/runs/${{github.run_id}} to view logs."}'\
--data '{"text":"k8sgateway Vulnerability Scan has failed, visit https://github.com/k8sgateway/k8sgateway/actions/runs/${{github.run_id}} to view logs."}'\
${{ env.SLACK_DEBUG_TESTING == true && secrets.SLACK_INTEGRATION_TESTING_WEBHOOK || secrets.EDGE_TEAM_BOTS_WEBHOOK }}
3 changes: 3 additions & 0 deletions changelog/v1.18.0-beta35/fix-notification-urls.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
changelog:
- type: NON_USER_FACING
description: Fix URLs in Slack notifications for GHAs such that they correctly link to actions in this repo.

0 comments on commit 5974a88

Please sign in to comment.