move snapshots interface to localhost #10302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keep pr updated
|
Visit the preview URL for this PR (updated for commit 1b27f44): https://gloo-edge--pr10302-yuval-k-snapshot-loc-2i93ab1z.web.app (expires Tue, 19 Nov 2024 06:42:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
Yes, i left it there just in case someone depends on the old functionality. if no one complains delete in 1.19 |
sam-heilbron
approved these changes
Nov 11, 2024
sam-heilbron
removed
the
work in progress
bleggett
reviewed
Nov 11, 2024
| "github.com/solo-io/go-utils/threadsafe" | ||
| ) | ||
|
|
||
| const ( | ||
| InputSnapshotPath = "/snapshots/input" | ||
| DefaultAdminPort = 9091 | ||
|
|
||
| DefaultAdminPort = admin.AdminPort |
There was a problem hiding this comment.
I'd almost say drop this export?
It's used here and in one (1) test, and in that test might as well import "github.com/solo-io/gloo/projects/gloo/pkg/servers/admin"
Not a big deal tho.
nfuden
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move the snapshots debug endpoints to a localhost only admin interface