-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxy api: support destination ip/port matching #9485
Conversation
Visit the preview URL for this PR (updated for commit f02fbf5): https://gloo-edge--pr9485-stevenctl-proxy-matc-1bxrsouj.web.app (expires Wed, 12 Jun 2024 22:21:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! Could we add some basic unit tests to demonstrate the new matching capabilities and perhaps an e2e test as well to show that the traffic is routed appropriately? https://github.com/solo-io/gloo/blob/main/test/e2e/hybrid_test.go#L172 Might be a good set of tests to build off of
d025d49
to
346e5e6
Compare
@sam-heilbron should be good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs
Co-authored-by: Rachael Graham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but looks like codegen needs to run (again for some reason).
I'll approve now but can reapprove when CI passes
I'm also happy to approve once dogs are fixed |
which dogs are you referring to? :) |
buildbot? |
Description
Allow filter chain matches to match on destination IP/port.
This bug fixes ... \ This new feature can be used to ...
API changes
In
Matcher
added:(continuing to duplicate what envoy has)
Code changes
Implement the translation from Proxy to Envoy xDS for the new fields.
This was only done in the same places that SourcePrefixRanges were already uses.
Context
Related to #9471
Interesting decisions
We chose to do things this way because ...
Testing steps
I manually verified behavior by relying on it in an experimental fork.
Checklist: