Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write SDMX-ML elements in XSD schema order #211

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Write SDMX-ML elements in XSD schema order #211

merged 5 commits into from
Dec 13, 2024

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Dec 12, 2024

Closes #210

PR checklist

  • Checks all ✅
  • Update documentation N/A, bugfix
  • Update doc/whatsnew.rst

@khaeru khaeru self-assigned this Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.94%. Comparing base (4116706) to head (47ba7a9).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   98.90%   97.94%   -0.97%     
==========================================
  Files          97       98       +1     
  Lines        8073     8088      +15     
==========================================
- Hits         7985     7922      -63     
- Misses         88      166      +78     
Files with missing lines Coverage Δ
sdmx/format/xml/__init__.py 100.00% <100.00%> (ø)
sdmx/tests/writer/test_writer_xml.py 100.00% <100.00%> (ø)
sdmx/writer/xml.py 98.06% <100.00%> (ø)

... and 19 files with indirect coverage changes

@khaeru
Copy link
Owner Author

khaeru commented Dec 12, 2024

@3nz01 changing that one line I pointed to appears to resolve the issue—at least in the one test added on this branch.

Please let me know if you will be able to test the fix in your actual workflow, or not. Once I hear from you I will merge and make a patch release.

@khaeru khaeru added bug writer Convert objects to other formats xml SDMX-ML format labels Dec 12, 2024
- Use %Y placeholder for copyright year.
@3nz01
Copy link

3nz01 commented Dec 12, 2024

@khaeru We weren't able to bring the entire project into our environment to test. However we did replicate the change you made on line 303 of sdmx/sdmx/writer/xml.py and it worked perfectly. From our POV the solution works and you can release the patch.

You might want to leave a note on the SIS-CC's gitlab saying that this has been taken care of. I don't mind doing it, but I figure you deserve the credit :)

Many thanks from the entire StatCan SDMX team.

@khaeru khaeru merged commit 4a44cbe into main Dec 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug writer Convert objects to other formats xml SDMX-ML format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDMX-ML element order issue
2 participants