security: Move issuer_is_self() to CertificateView

khevessy · Nov 17, 2024 · b93fb2f · b93fb2f
1 parent 7273031
commit b93fb2f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/vanetza/security/v3/certificate.cpp b/vanetza/security/v3/certificate.cpp
@@ -201,6 +201,11 @@ boost::optional<HashedId8> CertificateView::issuer_digest() const
     return digest;
 }
 
+bool CertificateView::issuer_is_self() const
+{
+    return m_cert->issuer.present == Vanetza_Security_IssuerIdentifier_PR_self;
+}
+
 bool CertificateView::has_region_restriction() const
 {
     return m_cert ? m_cert->toBeSigned.region != nullptr : false;
@@ -704,11 +709,6 @@ void Certificate::set_signature(const SomeEcdsaSignature& signature)
     m_struct->signature = boost::apply_visitor(signature_visitor(), signature);
 }
 
-bool Certificate::issuer_is_self() const
-{
-    return m_struct->issuer.present == Vanetza_Security_IssuerIdentifier_PR_self;
-}
-
 Certificate fake_certificate()
 {
     Certificate certi;

diff --git a/vanetza/security/v3/certificate.hpp b/vanetza/security/v3/certificate.hpp
@@ -51,6 +51,12 @@ class CertificateView
      */
     boost::optional<HashedId8> issuer_digest() const;
 
+    /**
+     * Check if certificate is self-signed
+     * \return true if certificate is self-signed
+     */
+    bool issuer_is_self() const;
+
     /**
      * Check if certificate is a Certification Authority certificate
      * \return true if certificate is a CA certificate
@@ -136,8 +142,6 @@ struct Certificate : public asn1::asn1c_oer_wrapper<asn1::EtsiTs103097Certificat
     void add_cert_permission(asn1::PsidGroupPermissions* group_permission);
 
     void set_signature(const SomeEcdsaSignature& signature);
-
-    bool issuer_is_self() const;
 };
 
 /**