Skip to content

Commit

Permalink
Support for updation of kiali-server helm value view_only_mode (#211)
Browse files Browse the repository at this point in the history
Prior to this change, the post installation update of the kiali-server
helm chart value deployment.view_only_mode fails as it tries to change
the roleRef which is immutable. This change tries to create a new
clusterrolebinding based on the view_only_mode configuration.

Fixes kiali/kiali#6139
  • Loading branch information
ayaranga authored May 22, 2023
1 parent 29f3668 commit 6865206
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions kiali-server/templates/rolebinding.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
{{- if or (.Values.deployment.view_only_mode) (ne .Values.auth.strategy "anonymous") }}
name: {{ include "kiali-server.fullname" . }}-viewer
{{- else }}
name: {{ include "kiali-server.fullname" . }}
{{- end }}
labels:
{{- include "kiali-server.labels" . | nindent 4 }}
roleRef:
Expand Down

0 comments on commit 6865206

Please sign in to comment.