♻️ Don't use retry Sessions #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znatty22
force-pushed
the
no-retry-session
branch
from
998debe to
20ec5c4
Compare
znatty22
force-pushed
the
no-retry-session
branch
from
20ec5c4 to
5bf83bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library uses retry sessions from d3b_utils but this makes debugging very difficult bc requests seem like they are hanging when really the session is just retrying. For now this branch is temporary, but we may consider using a normal Python requests Session without retries by default, while still giving the user the opportunity to use retry Sessions if they want.