[JBPM-10208] Avoid signalling the same engine more than once

In the same signalEvent call
kiegroup · Nov 7, 2023 · bc17dcb · bc17dcb
1 parent 5a9f791
commit bc17dcb
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/...manager/src/main/java/org/jbpm/runtime/manager/impl/PerProcessInstanceRuntimeManager.java b/...manager/src/main/java/org/jbpm/runtime/manager/impl/PerProcessInstanceRuntimeManager.java
@@ -165,12 +165,14 @@ public RuntimeEngine getRuntimeEngine(Context<?> context) {
     public void signalEvent(String type, Object event) {
 
         // first signal with new context in case there are start event with signal
+        Set<RuntimeEngine> signalledEngines = new HashSet<>();
         KieSession signalSession = null;
         RuntimeEngine runtimeEngine = getRuntimeEngine(ProcessInstanceIdContext.get());
         try {
             // signal execution can rise errors
             signalSession = runtimeEngine.getKieSession();
             signalSession.signalEvent(type, event);
+            signalledEngines.add(runtimeEngine);
         } finally {
             // ensure we clean up
             if(signalSession!=null) {
@@ -179,13 +181,17 @@ public void signalEvent(String type, Object event) {
             disposeRuntimeEngine(runtimeEngine);
         }
 
+
         // next find out all instances waiting for given event type
         List<String> processInstances = ((InternalMapper) mapper).findContextIdForEvent(type, getIdentifier());
         for (String piId : processInstances) {
             runtimeEngine = getRuntimeEngine(ProcessInstanceIdContext.get(Long.parseLong(piId)));
             try {
                 // signal execution can rise errors
-                runtimeEngine.getKieSession().signalEvent(type, event);
+                if (!signalledEngines.contains(runtimeEngine)) {
+                    runtimeEngine.getKieSession().signalEvent(type, event);
+                    signalledEngines.add(runtimeEngine);
+                }
             } finally {
                 // ensure we clean up
                 disposeRuntimeEngine(runtimeEngine);
@@ -215,8 +221,11 @@ public void signalEvent(String type, Object event) {
                 if (context != null && context instanceof ProcessInstanceIdContext 
                         && ((ProcessInstanceIdContext) context).getContextId() != null) {
                     try {
-                        engineImpl.getKieSession().signalEvent(type, event,
+                        if (!signalledEngines.contains(engineImpl)) {
+                            engineImpl.getKieSession().signalEvent(type, event,
                                 ((ProcessInstanceIdContext) context).getContextId());
+                            signalledEngines.add(engineImpl);
+                        }
                     } catch (org.drools.persistence.api.SessionNotFoundException ex) {
                         logger.warn(
                                 "Signal event cannot proceed because of session not found exception {} for engine {}",