-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[incubator-kie-issues-646] Duplicate timer created for Task SLA Due date with AsyncMode env setting #2352
Conversation
…ate with AsyncMode env setting
the async node access the metadata of the node being wrapped causing the node itself registering an SLA twice |
SonarCloud Quality Gate failed. 1 Bug 50.0% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and clean fix, thanks @elguardian
jenkins do fdb |
@gmunozfe need this to be reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, great fix @elguardian !
could you look at sonar problem at https://sonarcloud.io/project/issues?resolved=false&types=BUG&pullRequest=2352&id=org.jbpm%3Ajbpm&open=AYtrkrLmJ56keKDifEdB ? |
…ate with AsyncMode env setting (#2352)
…ate with AsyncMode env setting (#2352)
@martinweiler this #2355 should be in when creating the patch as well. |
…ate with AsyncMode env setting (kiegroup#2352)
…SLA Due date with AsyncMode env setting (#2354) * [incubator-kie-issues-646] Duplicate timer created for Task SLA Due date with AsyncMode env setting (#2352) * fixed recursion Co-authored-by: Gonzalo Muñoz <[email protected]> --------- Co-authored-by: Enrique <[email protected]> Co-authored-by: Marek Novotný <[email protected]> Co-authored-by: Gonzalo Muñoz <[email protected]>
…Task SLA Due date with AsyncMode env setting (#2353) * [incubator-kie-issues-646] Duplicate timer created for Task SLA Due date with AsyncMode env setting (#2352) * Update jbpm-flow/src/main/java/org/jbpm/workflow/core/node/AsyncEventNode.java Co-authored-by: Gonzalo Muñoz <[email protected]> --------- Co-authored-by: Enrique <[email protected]> Co-authored-by: Marek Novotný <[email protected]> Co-authored-by: Gonzalo Muñoz <[email protected]>
issue: apache/incubator-kie-issues#646