-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[private-bamoe-issues#1326] Avoid duplicate timer execution with long running timers and async nodes #2373
Conversation
… running timers and async nodes
jbpm-flow/src/main/java/org/jbpm/process/core/timer/impl/GlobalTimerService.java
Outdated
Show resolved
Hide resolved
jbpm-flow/src/main/java/org/jbpm/process/core/timer/impl/GlobalTimerService.java
Outdated
Show resolved
Hide resolved
jbpm-flow/src/main/java/org/jbpm/process/core/timer/impl/GlobalTimerService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions.
Great work @martinweiler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, though @fjtirado suggestions seem fine to be considered
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
… running timers and async nodes (#2373) * [private-bamoe-issues#1326] Avoid duplicate timer execution with long running timers and async nodes * [private-bamoe-issues#1326] Simplify the equals/hashCode methods
… running timers and async nodes (#2373) * [private-bamoe-issues#1326] Avoid duplicate timer execution with long running timers and async nodes * [private-bamoe-issues#1326] Simplify the equals/hashCode methods
… running timers and async nodes (#2373) (#2376) * [private-bamoe-issues#1326] Avoid duplicate timer execution with long running timers and async nodes * [private-bamoe-issues#1326] Simplify the equals/hashCode methods Co-authored-by: Martin Weiler <[email protected]>
… running timers and async nodes (#2373) (#2375) * [private-bamoe-issues#1326] Avoid duplicate timer execution with long running timers and async nodes * [private-bamoe-issues#1326] Simplify the equals/hashCode methods Co-authored-by: Martin Weiler <[email protected]>
JIRA: https://issues.redhat.com/browse/RHPAM-4864
Add equals/hashCode methods in order to ensure List.contains works properly.