Fix error in building BASEHREF for skosmos

[FelixFrizzy]

• Removed double http when building URL for skosmos

Summary by CodeRabbit

• Configuration
  • Updated default URL configuration for development and live services
  • Removed redundant http:// prefix from default environment variables in Docker Compose file

[coderabbitai]

Walkthrough

The pull request involves subtle modifications to the docker-compose.yml file, specifically adjusting the environment variables BASEHREFDEV and BASEHREFLIVE for the skosmos-dev and skosmos-live services. The primary change is the removal of the default http:// prefix from the PUBLICURL variable, which could impact how URLs are constructed when the variable is not explicitly defined.

Changes

File	Change Summary
docker-compose.yml	Removed default http:// prefix from BASEHREFDEV and BASEHREFLIVE environment variables in skosmos-dev and skosmos-live services

Poem

🐰 A Docker Rabbit's Verse 🐰

In YAML's realm, a subtle dance,
Where URLs twirl without their stance,
No http:// to lead the way,
Just localhost's playful sway,
A compose-time magic, light and free! 🌈

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 73345f1 and 5beb379.

📒 Files selected for processing (1)

• docker-compose.yml (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: test-all
• GitHub Check: test-all

🔇 Additional comments (2)

docker-compose.yml (2)

156-156: LGTM! This change fixes the double "http://" issue.

The modification correctly addresses the URL construction issue by removing the redundant http:// prefix from the default value. Now when PUBLICURL is not set, it will correctly resolve to http://localhost:9000/skosmos-dev/ instead of the malformed http://http://localhost:9000/skosmos-dev/.

---

185-185: LGTM! This change fixes the double "http://" issue.

The modification correctly addresses the URL construction issue by removing the redundant http:// prefix from the default value. Now when PUBLICURL is not set, it will correctly resolve to http://localhost:9000/skosmos-live/ instead of the malformed http://http://localhost:9000/skosmos-live/.

Please ensure that when setting the PUBLICURL environment variable, it does not include the http:// prefix, as it's already added in the BASEHREF variables. For example:

• Correct: PUBLICURL=example.com
• Incorrect: PUBLICURL=http://example.com

Let's verify the current usage:

✅ Verification successful

PUBLICURL usage verified - no issues found

The codebase search confirms that PUBLICURL is only used in the BASEHREF* environment variables within docker-compose.yml, and there are no instances of incorrect usage with http:// prefix. The code is self-documenting as the variable usage pattern is clear from the environment variable definitions themselves.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for PUBLICURL assignments in the repository
rg -l "PUBLICURL=[\"']?http://" .

Length of output: 37

---

Script:

#!/bin/bash
# Search for any PUBLICURL mentions in documentation and configs
rg -i "publicurl" --type md --type yaml --type env

Length of output: 78

---

Script:

#!/bin/bash
# Search for PUBLICURL in docker-compose files and any text content
rg -i "publicurl" --type yaml
rg -i "publicurl" -t txt

Length of output: 266

Finishing Touches

• 📝 CodeRabbit is generating docstrings... (♻️ Check again to generate again)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Caution

No docstrings were generated.