Adds integers_stubs_js & modifies js_of_ocaml. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update - ocsigen/js_of_ocaml#1296 got merged so I have added a commit to restore |
dra27
reviewed
Jul 29, 2022
| build: ["dune" "build" "-p" name "-j" jobs] | ||
| dev-repo: "git+https://github.com/o1-labs/integers_stubs_js.git" | ||
| url { | ||
| src: "https://github.com/o1-labs/integers_stubs_js/archive/1.0.tar.gz" |
There was a problem hiding this comment.
This is the same as the upstream package, isn't it?
There was a problem hiding this comment.
It wants to point to your branch, though - https://github.com/novemberkilo/integers_stubs_js/archive/master.tar.gz (no checksum needed)
There was a problem hiding this comment.
The mainline repo should build with the updated js_of_ocaml branch so we shouldn't need my fork here?
There was a problem hiding this comment.
I'm just fixing a test related issue on my branch
|
Since the original package in opam-repository works and the tests aren’t ran I’ll close this. Thanks a lot for ocsigen/js_of_ocaml#1296 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Owing to its revdeps, I investigated
integers_stubs_jsto see if I could get it building and installing with OCaml5. This is its failing build on ocaml-health-check.Apparently the issue was with its dependency -
js_of_ocaml-compilerand following a helpful hint from @dra27 I put up this PR on their WIPocaml-5branch. With this fix, I am able to build and installjs_of_ocamlon 5.0~alpha -- it is for this reason that I have modifiedjs_of_ocamlhere to point to my fork.During this investigation I also found a minor issue that was causing
integers_stubs_jsto not build and I fixed this with this PRThis is my first foray at contributing to the Great OCaml5 Effort - hopefully I've got the various moving parts in the right spots so that
integers_stubs_jscan go green across the board on opam-health-check