merge with upstream 1.0.37 (#5)

kitsteam · Sep 15, 2024 · 2fa1f01 · 2fa1f01
1 parent 28d8450
commit 2fa1f01
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.github/workflows/npmpublish.yml b/.github/workflows/npmpublish.yml
@@ -21,7 +21,7 @@ jobs:
       - uses: pnpm/action-setup@v3
         name: Install pnpm
         with:
-          version: 8
+          version: 9
           run_install: false
       - name: Get pnpm store directory
         shell: bash

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "description": "Adds comments on sidebar and link it to the text.  For no-skin use ep_page_view.",
   "name": "ep_comments_page",
-  "version": "1.0.36",
+  "version": "1.0.37",
   "author": {
     "name": "Nicolas Lescop",
     "email": "[email protected]"

diff --git a/static/js/index.js b/static/js/index.js
@@ -791,7 +791,12 @@ EpComments.prototype.getCommentData = function () {
 
 // Delete a pad comment
 EpComments.prototype.deleteComment = function (commentId) {
-  $('iframe[name="ace_outer"]').contents().find(`#${commentId}`).remove();
+  while($('iframe[name="ace_outer"]').contents().find(`#${commentId}`).length > 0){
+    $('iframe[name="ace_outer"]').contents().find(`#${commentId}`).remove();
+  }
+  while($('iframe[name="ace_outer"]').contents().find(`#icon-${commentId}`).length > 0){
+    $('iframe[name="ace_outer"]').contents().find(`#icon-${commentId}`).remove();
+  }
 };
 
 const cloneLine = (line) => {