Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dependency checking #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ESilva15
Copy link

Added an array with the dependencies binary names to check for.
Pros:

  • Checking for a new dependency is as simple as adding it to the array;
  • Throws all required dependencies at once. Otherwise one would have
    to install one dependency and see what else is missing and so on;
  • Faster to read.
    Cons:
  • Might be harder to read.

NOTE: sorry for the lack of history on this GitHub account, I deleted the older one.

Added an array with the dependencies binary names to check for.
Pros:
  - Checking for a new dependency is as simple as adding it to the ar>
  - Throws all required dependencies at once. Otherwise one would have
    to install one dependency and see what else is missing and so on;
  - Faster to read.
Cons:
  - Might be harder to read.
@klaxalk
Copy link
Owner

klaxalk commented May 24, 2022

Thanks, this is a great idea :-). One little remark: The original dependency check searched for vim or nvim. Now, it requires both. Could you please update your method (I don't have a tip now on how to do it in an elegant way)? I would do it myself, but I am currently a little busy. Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants