Skip to content

Commit

Permalink
docs: update for a better env name (#144)
Browse files Browse the repository at this point in the history
Co-authored-by: Siyuan Wang <[email protected]>
  • Loading branch information
Thrimbda and Siyuan Wang authored Oct 25, 2020
1 parent 4889fc2 commit dc7d291
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions docs/tutorial-serving-seldon.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ Then we can get the model in the Harbor UI.

### Helm Chart

We need to deploy Seldon Core on Kubernetes.
We need to deploy Seldon Core on Kubernetes.

If you are using Helm Chart to deploy Seldon Core, there are some changes need to be done in [helm-charts/seldon-core-operator/values.yaml#L80](https://github.com/SeldonIO/seldon-core/blob/00c691d0f947f5fe21fb408dd613a669d87062fc/helm-charts/seldon-core-operator/values.yaml#L80) and [helm-charts/seldon-core-operator/values.yaml#L137](https://github.com/SeldonIO/seldon-core/blob/00c691d0f947f5fe21fb408dd613a669d87062fc/helm-charts/seldon-core-operator/values.yaml#L137)

Expand All @@ -77,8 +77,8 @@ storageInitializer:
s3:
- s3AccessKeyIDName: awsAccessKeyID
- s3SecretAccessKeyName: awsSecretAccessKey
+ s3AccessKeyIDName: ormbUsername
+ s3SecretAccessKeyName: ormbPassword
+ s3AccessKeyIDName: ORMB_USERNAME
+ s3SecretAccessKeyName: ORMB_PASSWORD
```

### Local Development
Expand All @@ -94,8 +94,8 @@ If you are using the guide in [Seldon Core Development Documentation](https://do
"s3" : {
- "s3AccessKeyIDName": "awsAccessKeyID",
- "s3SecretAccessKeyName": "awsSecretAccessKey"
+ "s3AccessKeyIDName": "ormbUsername",
+ "s3SecretAccessKeyName": "ormbPassword"
+ "s3AccessKeyIDName": "ORMB_USERNAME",
+ "s3SecretAccessKeyName": "ORMB_PASSWORD"
}
}
...
Expand Down Expand Up @@ -146,9 +146,9 @@ metadata:
type: Opaque
data:
# base64 formatted username `ormbtest`
ormbUsername: b3JtYnRlc3Q=
ORMB_USERNAME: b3JtYnRlc3Q=
# base64 formatted password `ORMBtest12345`
ormbPassword: T1JNQnRlc3QxMjM0NQ==
ORMB_PASSWORD: T1JNQnRlc3QxMjM0NQ==
---
apiVersion: v1
kind: ServiceAccount
Expand Down

0 comments on commit dc7d291

Please sign in to comment.