Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chord visualization #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix chord visualization #37

wants to merge 1 commit into from

Conversation

dann-merlin
Copy link

This commit fixes two issues with chord visualizations.

  1. Open strings were not shown as such. Instead they were visualized with an "x", as if you wouldn't play them at all.
  2. Chords that were theoretically close enough to the 0th fret still started at a later fret (the first one with a pressed string), like the 2nd or 3rd.

Fix chord visualization
3369ae1 
This commit fixes two issues with chord visualizations.
1. Open strings were not shown as such. Instead they were
visualized with an "x", as if you wouldn't play them at all.
2. Chords that were theoretically close enough to the 0th fret
still started at a later fret (the first one with a pressed string),
like the 2nd or 3rd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dann-merlin