Skip to content

Update knative deps #9051

Update knative deps

Update knative deps #9051

Triggered via pull request January 23, 2025 08:45
Status Failure
Total duration 2m 48s
Artifacts

knative-style.yaml

on: pull_request
style  /  changes
7s
style / changes
style  /  ...  /  Auto-format and Check
16s
style / Golang / Auto-format and Check
style  /  ...  /  Lint
2m 22s
style / Golang / Lint
style  /  ...  /  Do Not Submit
15s
style / Golang / Do Not Submit
style  /  ...  /  shell
43s
style / suggester / shell
style  /  ...  /  yaml
36s
style / suggester / yaml
style  /  ...  /  github_actions
0s
style / suggester / github_actions
Matrix: style / Golang / Boilerplate Check
Fit to window
Zoom out
Zoom in

Annotations

12 errors and 8 warnings
style / Golang / Boilerplate Check (go): control-plane/pkg/contract/contract.pb.go#L1
[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: control-plane/pkg/contract/contract.pb.go:1: missing boilerplate: /* * Copyright 2025 The Knative Authors * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */
style / Golang / Boilerplate Check (go)
Process completed with exit code 1.
style / Golang / Lint: control-plane/pkg/kafka/offset/offsets.go#L94
G115: integer overflow conversion int -> int32 (gosec)
style / Golang / Lint: control-plane/pkg/reconciler/testing/objects_broker.go#L30
SA1019: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (staticcheck)
style / Golang / Lint: control-plane/pkg/reconciler/testing/objects_channel.go#L30
SA1019: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (staticcheck)
style / Golang / Lint: control-plane/pkg/reconciler/testing/objects_common.go#L39
SA1019: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (staticcheck)
style / Golang / Lint: test/rekt/features/leases.go#L53
SA1019: wait.Poll is deprecated: This method does not return errors from context, use PollUntilContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
style / Golang / Lint: test/rekt/features/namespace.go#L67
SA1019: wait.PollImmediate is deprecated: This method does not return errors from context, use PollUntilContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
style / Golang / Lint: test/rekt/resources/configmap/wait.go#L42
SA1019: wait.PollImmediate is deprecated: This method does not return errors from context, use PollUntilContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
style / Golang / Lint: test/upgrade/postupgrade.go#L53
SA1019: wait.Poll is deprecated: This method does not return errors from context, use PollUntilContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
style / Golang / Lint: control-plane/pkg/reconciler/channel/controller.go#L132
`NewController$3` - `obj` is unused (unparam)
style / Golang / Lint: test/rekt/resources/kafkasource/kafkasource.go#L67
SA1019: wait.PollImmediate is deprecated: This method does not return errors from context, use PollUntilContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
style / changes
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-kafka-broker/eventing-kafka-broker. Supported file pattern: go.sum
style / Golang / Do Not Submit
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-kafka-broker/eventing-kafka-broker. Supported file pattern: go.sum
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-kafka-broker/eventing-kafka-broker. Supported file pattern: go.sum
style / suggester / yaml
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
style / suggester / shell
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-kafka-broker/eventing-kafka-broker. Supported file pattern: go.sum