Skip to content

Commit

Permalink
Bump to 3.10.x Quarkus.io and align libraries (#3872)
Browse files Browse the repository at this point in the history
* Bump quarkus BOM to get newer vert.x

Signed-off-by: Matthias Wessendorf <[email protected]>

* Use unwrapped verxInternal's tracer()

Signed-off-by: Matthias Wessendorf <[email protected]>

* Revert "Use unwrapped verxInternal's tracer()"

This reverts commit dfc8b4a.

* Fix ReceiverVerticleTracingTest#traceIsPropagated

In Vert.x 4.5.1, there was a fix to use the OTel default context storage when the Vert.x context storage provider is not invoked on a Vert.x thread.
See eclipse-vertx/vertx-tracing#72

Since LoomKafkaProducer invokes the tracer on a virtual thread (or a worker thread), the sending task must be wrapped with the OTel current context.
Otherwise, tracing data will be lost at this point.

OTel provides an ExecutorService that does just that, so this commit refactors the producer to use an executor service instead of a queue plus manual polling.

Important: note that with this implementation, a virtual thread is created for each record, which is different from sending them one after the other with a single thread.

---------

Signed-off-by: Matthias Wessendorf <[email protected]>
Co-authored-by: Thomas Segismont <[email protected]>
  • Loading branch information
matzew and tsegismont authored Jan 14, 2025
1 parent bcfacd5 commit 0b4e723
Show file tree
Hide file tree
Showing 4 changed files with 143 additions and 174 deletions.
Loading

0 comments on commit 0b4e723

Please sign in to comment.