Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #3412

Merged

Conversation

creydr
Copy link
Contributor

@creydr creydr commented Oct 19, 2023

Fix build issues from #3410

@creydr creydr requested review from aliok and pierDipi October 19, 2023 14:04
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@knative-prow knative-prow bot requested a review from Cali0707 October 19, 2023 14:05
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test labels Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #3412 (c5a0002) into main (992d623) will increase coverage by 3.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3412      +/-   ##
============================================
+ Coverage     58.37%   61.50%   +3.12%     
- Complexity        0      762     +762     
============================================
  Files            91      181      +90     
  Lines          9285    12362    +3077     
  Branches          0      265     +265     
============================================
+ Hits           5420     7603    +2183     
- Misses         3431     4159     +728     
- Partials        434      600     +166     
Flag Coverage Δ
java-unittests 70.94% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 90 files with indirect coverage changes

@Cali0707
Copy link
Member

/test unit-tests

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for fixing the update @creydr !

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Contributor Author

creydr commented Oct 19, 2023

/retest

@Cali0707
Copy link
Member

/restest-required

@creydr
Copy link
Contributor Author

creydr commented Oct 19, 2023

/retest

1 similar comment
@creydr
Copy link
Contributor Author

creydr commented Oct 19, 2023

/retest

@knative-prow knative-prow bot merged commit 36cf0b4 into knative-extensions:main Oct 19, 2023
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants