Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to latest Quarkus (3.2.7.Final) #3413

Closed
wants to merge 1 commit into from

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Oct 23, 2023

Fixes #

Proposed Changes

  • as per title

Release Note


Docs

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2023
@knative-prow knative-prow bot requested review from aliok and lionelvillard October 23, 2023 06:07
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #3413 (cf29ceb) into main (36cf0b4) will increase coverage by 0.02%.
Report is 7 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3413      +/-   ##
============================================
+ Coverage     61.47%   61.50%   +0.02%     
- Complexity      761      762       +1     
============================================
  Files           181      181              
  Lines         12362    12362              
  Branches        265      265              
============================================
+ Hits           7600     7603       +3     
+ Misses         4161     4159       -2     
+ Partials        601      600       -1     
Flag Coverage Δ
java-unittests 70.94% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@creydr
Copy link
Contributor

creydr commented Oct 23, 2023

/retest

1 similar comment
@matzew
Copy link
Contributor Author

matzew commented Oct 23, 2023

/retest

Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow
Copy link

knative-prow bot commented Oct 23, 2023

@matzew: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
channel-reconciler-tests-ssl_eventing-kafka-broker_main cf29ceb link unknown /test channel-reconciler-tests-ssl
channel-integration-tests-ssl_eventing-kafka-broker_main cf29ceb link unknown /test channel-integration-tests-ssl

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2023
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matzew
Copy link
Contributor Author

matzew commented Oct 25, 2023

/close

contained in #3426

@knative-prow
Copy link

knative-prow bot commented Oct 25, 2023

@matzew: Closed this PR.

In response to this:

/close

contained in #3426

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants