Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup NewTriggerFilters e2e test #3513

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

creydr
Copy link
Contributor

@creydr creydr commented Dec 6, 2023

Follow up on 4aea983#r1415739180

/cc @Cali0707

@creydr creydr requested a review from Cali0707 December 6, 2023 09:17
@knative-prow knative-prow bot added area/test approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2023
@creydr creydr mentioned this pull request Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b581b7) 61.53% compared to head (da28bee) 61.52%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3513      +/-   ##
============================================
- Coverage     61.53%   61.52%   -0.01%     
+ Complexity      765      764       -1     
============================================
  Files           181      181              
  Lines         12414    12414              
  Branches        266      266              
============================================
- Hits           7639     7638       -1     
  Misses         4165     4165              
- Partials        610      611       +1     
Flag Coverage Δ
java-unittests 70.83% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr
Copy link
Contributor Author

creydr commented Dec 6, 2023

/retest

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
Copy link

knative-prow bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Contributor Author

creydr commented Dec 6, 2023

/retest

4 similar comments
@creydr
Copy link
Contributor Author

creydr commented Dec 6, 2023

/retest

@creydr
Copy link
Contributor Author

creydr commented Dec 7, 2023

/retest

@matzew
Copy link
Contributor

matzew commented Dec 7, 2023

/retest

@matzew
Copy link
Contributor

matzew commented Dec 7, 2023

/retest

@matzew matzew merged commit 6a5dfcb into knative-extensions:main Dec 7, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants