-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: receiver verticle now has a grace period before closing #3896
base: main
Are you sure you want to change the base?
feat: receiver verticle now has a grace period before closing #3896
Conversation
/cc @pierDipi |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3896 +/- ##
=============================================
- Coverage 73.70% 49.69% -24.02%
=============================================
Files 100 246 +146
Lines 3419 14849 +11430
Branches 292 0 -292
=============================================
+ Hits 2520 7379 +4859
- Misses 723 6711 +5988
- Partials 176 759 +583
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Calum Murray <[email protected]>
8446d9e
to
17674ca
Compare
/retest-required |
@Cali0707: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This Pull Request is stale because it has been open for 90 days with |
Fixes #1684
Proposed Changes
Release Note