Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: receiver verticle now has a grace period before closing #3896

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Cali0707
Copy link
Member

Fixes #1684

Proposed Changes

  • Add parameter to ReceiverVerticleFactory for how long to wait before closing the http servers in the receiver
  • Use timeout in the receiver stop handler to wait until the grace period has finished before closing the servers

Release Note

The receiver http/https servers now wait for 20 seconds after receiving SIGTERM before closing, helping with more graceful shutdown

@knative-prow knative-prow bot requested review from lionelvillard and matzew May 14, 2024 15:03
@Cali0707
Copy link
Member Author

/cc @pierDipi

Copy link

knative-prow bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 14, 2024
@knative-prow knative-prow bot requested a review from pierDipi May 14, 2024 15:03
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.69%. Comparing base (aacc057) to head (17674ca).
Report is 151 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (aacc057) and HEAD (17674ca). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (aacc057) HEAD (17674ca)
java-unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3896       +/-   ##
=============================================
- Coverage     73.70%   49.69%   -24.02%     
=============================================
  Files           100      246      +146     
  Lines          3419    14849    +11430     
  Branches        292        0      -292     
=============================================
+ Hits           2520     7379     +4859     
- Misses          723     6711     +5988     
- Partials        176      759      +583     
Flag Coverage Δ
java-unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cali0707 Cali0707 force-pushed the receiver-waits-before-closing branch from 8446d9e to 17674ca Compare May 14, 2024 15:14
@Cali0707
Copy link
Member Author

/retest-required

Copy link

knative-prow bot commented May 14, 2024

@Cali0707: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests-namespaced-broker_eventing-kafka-broker_main 17674ca link true /test reconciler-tests-namespaced-broker

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 11, 2024
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Waits for service endpoints propagation on shutdown in Receiver
2 participants