add configurable CE metadata extension prefix

[cchayka-campsci]

Proposed Changes

• allow the CloudEvent extension attributes "partition" and "offset" to have a customizable prefix

As brought up before in this issue #3992, a previous version of NodeJS cloudevents would throw an error for any extension > 20 chars in length.

We are in a tough position to update this package for a large number of legacy services, so we were hoping you could consider allowing this change.

Basically just adding a new env var "CE_METADATA_EXTENSION_PREFIX" to change the "knativekafka" part of the "knativekafkapartition" and "knativekafkaoffset" CE extensions.

Release Note

:broom: allow customization of the prefix of the CE extensions

Docs

previous pull request to the wrong branch: #4144

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cchayka-campsci
Once this PR has been reviewed and has the lgtm label, please assign lionelvillard for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[linux-foundation-easycla]

• ✅login: cchayka-campsci / (fad5d55)

The committers listed above are authorized under a signed CLA.

[knative-prow]

Hi @cchayka-campsci. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pierDipi]

/ok-to-test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.51%. Comparing base (1616ec3) to head (fad5d55).
Report is 7 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #4164      +/-   ##
============================================
- Coverage     49.33%   45.51%   -3.82%     
============================================
  Files           374      270     -104     
  Lines         23479    19925    -3554     
  Branches        313        0     -313     
============================================
- Hits          11583     9069    -2514     
+ Misses        10993    10129     -864     
+ Partials        903      727     -176     

Flag	Coverage Δ
java-unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[matzew]

was there any feedback from the node.js library on why they fail - even the spec says should ?

CC @Cali0707

Asking here, instead of adding all this code for pluggable prefixes

[cchayka-campsci]

The node.js library was updated successfully. We are in a tough position to update some of our legacy services so were hoping this change could be considered regardless.

[Cali0707]

Yeah, we fixed it in the SDK since as you said @matzew this was a "should" requirement. But, I guess that doesn't fix it if people are using a non-fixed version of the SDK