Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite flaky broker_deleted_recreated #4175

Conversation

maschmid
Copy link
Contributor

Fixes a flaky BrokerDeletedRecreated test,

the current implementation is not guaranteed to succeed, as it is not defined when the dataplane will reconfigure itself once the old trigger is deleted, so it may sometimes occur, that the new event is still sent to the fist sink, and not the new one.

This new implementation checks that eventually, a sequence is only being received by the other sink.

This approach requires new kinds of assertions about a sequence, instead of just individual events received/not received, hence there is a proposal for some kind of a DSL for assertions over such sequences...

I am not quite sure this kind of DSL is a good idea or if it would be useful in other scenarios, so I could also just rewrite this with just a single one-purpose function instead, if we think there's not much value in it...

Proposed Changes

  • 🧹 Fix a flaky BrokerDeletedRecreated

@knative-prow knative-prow bot requested review from Cali0707 and pierDipi November 27, 2024 19:05
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.49%. Comparing base (a5af375) to head (37ec203).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4175      +/-   ##
==========================================
- Coverage   45.50%   45.49%   -0.02%     
==========================================
  Files         270      270              
  Lines       19873    19873              
==========================================
- Hits         9044     9041       -3     
- Misses      10111    10113       +2     
- Partials      718      719       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maschmid
Copy link
Contributor Author

maschmid commented Dec 4, 2024

/retest-required

1 similar comment
@maschmid
Copy link
Contributor Author

maschmid commented Jan 9, 2025

/retest-required

@maschmid maschmid force-pushed the maschmid-main-broker-deleted-recreated-rewrite branch from 70f852e to 7844eae Compare January 9, 2025 11:09
@pierDipi
Copy link
Member

pierDipi commented Jan 9, 2025

/retest
/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
Copy link

knative-prow bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maschmid, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@knative-prow knative-prow bot merged commit d90c382 into knative-extensions:main Jan 9, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants