Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upload-artifact action to v4 #4209

Merged

Conversation

creydr
Copy link
Contributor

@creydr creydr commented Jan 10, 2025

Fixes

Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v2`. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

e.g in https://github.com/knative-extensions/eventing-kafka-broker/actions/runs/12588648354/job/35086964011

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/test approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 10, 2025
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025
Copy link

knative-prow bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.44%. Comparing base (d90c382) to head (2f564e6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4209      +/-   ##
==========================================
- Coverage   45.50%   45.44%   -0.07%     
==========================================
  Files         270      270              
  Lines       19873    19893      +20     
==========================================
- Hits         9044     9041       -3     
- Misses      10111    10133      +22     
- Partials      718      719       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr
Copy link
Contributor Author

creydr commented Jan 10, 2025

/retest-required

1 similar comment
@pierDipi
Copy link
Member

/retest-required

@creydr
Copy link
Contributor Author

creydr commented Jan 10, 2025

/test reconciler-tests

@knative-prow knative-prow bot merged commit bcfacd5 into knative-extensions:main Jan 10, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants